LGTM! On Feb 21, 2014, at 2:22 PM, Ben Langmuir <[email protected]> wrote:
> Changes per review feedback. Interesting changes are: > > * new version field, and tests that check that it exists (and is currently 0) > * diagnostics are now counted in tests > * normalizePath is gone; . and .. entries will not work (but they didn't > *really* work in my previous patch either. > * all keys are now stored in a map so that we can easily check for > duplicates or ensure required keys are present. This is likely slower and > right now might even be more code, but is much easier to manage. > > Hi akyrtzi, > > http://llvm-reviews.chandlerc.com/D2835 > > CHANGE SINCE LAST DIFF > http://llvm-reviews.chandlerc.com/D2835?vs=7220&id=7290#toc > > Files: > include/clang/Basic/VirtualFileSystem.h > lib/Basic/VirtualFileSystem.cpp > unittests/Basic/VirtualFileSystemTest.cpp > <D2835.2.patch> _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
