================
Comment at: runtime/CMakeLists.txt:33
@@ +32,3 @@
+    )
+  # Due to a bug, DEPENDS in ExternalProject_Add doesn't work in some CMake 
versions.
+  add_dependencies(compiler-rt llvm-config clang clang++)
----------------
This should mention the versions of CMake, 2.8.9 and 2.8.10, so that when the 
minimum required version is high enough in the future one may be reminded to 
update the code to use the DEPENDS option.


================
Comment at: runtime/CMakeLists.txt:52
@@ +51,3 @@
+  add_custom_target(check-compiler-rt
+          COMMAND ${CMAKE_BUILD_TOOL} check-all
+          DEPENDS compiler-rt
----------------
This can use the command

%%% 
 ${CMAKE_COMMAND} --build . --target check-all --config $<CONFIGURATION>
%%%

to abstract the command-line details of the native build tool.



http://llvm-reviews.chandlerc.com/D2868
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to