As an example of other compilers, icc can emit diagnostics like this (with -vec-report2 flag):
s.cpp(42): (col. 9) remark: loop was not vectorized: existence of vector dependence 2014-02-25 15:29 GMT+04:00 Chris Lattner <[email protected]>: > > On Feb 25, 2014, at 2:41 AM, Tobias Grosser <[email protected]> wrote: > > > On 02/25/2014 11:32 AM, David Majnemer wrote: > >> You've added some extra whitespace in the definition > >> of CXDiagnosticSeverity. > >> Perhaps more importantly, the enum isn't in increasing order anymore. > > > > Hi David, > > > > thanks for the fast review. > > > > I fixed the whitespace issue. > > > > The order was intentional. I wanted to list the fields sorted by > severity, because this is how they are sorted logically. However, we need > to use '= 5' for the new diagnostic to not break the ABI here (these are > the c bindings). Would you propose another way to write this enum? > > Is "remark" better than "informative" diagnostics? Is there prior art in > other compilers that would be worth following? > > -Chris > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > -- Best regards, Alexander Musman +79154687051 skype: alexander.musman
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
