Am 03.03.2014 um 16:44 schrieb Dmitri Gribenko <[email protected]>:
> On Mon, Mar 3, 2014 at 1:59 PM, Jonathan 'Rynn' Sauer > <[email protected]> wrote: >> Hello, >> >> attached is a small patch to fix PR19024, "#define __FLOAT_H is likely to >> clash in float.h" >> (<http://llvm.org/bugs/show_bug.cgi?id=19024>). Please review and, if ok, >> commit. > > Which header file did this clash with? Was it a part of libc? If so, > then the change makes sense to me. While the identifier is reserved > for the implementation, apart from the compiler there are other pieces > which are also part of the implementation. But if it was a normal > project, then using reserved identifiers is their fault. You're right. While __CLANG_FLOAT_H is less likely to clash with user identifiers than __FLOAT_H, in the end the user should change their code to be standards-compliant. I'm closing the bug. Jonathan _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
