LGTM.
I think it makes sense to have -fopenmp=libgomp work as well. First, for
consistency. But also, for users who are depending on the current -fopenmp
behavior, this will give them some time to migrate to a stable flag before we
switch the default.
================
Comment at: lib/Driver/Tools.cpp:5243
@@ +5242,3 @@
+ CmdArgs.push_back("-liomp5");
+ else
+
getToolChain().getDriver().Diag(diag::err_drv_unsupported_option_argument)
----------------
This seems somewhat asymmetric: we now have -fopenmp, which links libgomp, and
-fopenmp=libiomp5 which links libiomp5. How about having -fopenmp=libgomp link
libgomp too?
================
Comment at: lib/Driver/Tools.cpp:6844
@@ +6843,3 @@
+ CmdArgs.push_back("-liomp5");
+ else
+ D.Diag(diag::err_drv_unsupported_option_argument)
----------------
Same here.
http://llvm-reviews.chandlerc.com/D2841
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
