================
Comment at: lib/Sema/SemaOpenMP.cpp:796-797
@@ -792,1 +795,4 @@
+ExprResult Sema::PerformImplicitIntegerConversion(SourceLocation Loc,
+ Expr *Op) {
+ if (!Op)
----------------
Alexey Bataev wrote:
> Dmitri Gribenko wrote:
> > This looks very much like code in Sema::BuildCXXNew(). If that code can be
> > replaced with a call to this function (possibly generalized, if it needs to
> > emit OMP-specific diagnostics), please do this.
> There are different diagnostics messages for these operations. I don't think
> it is a good idea to generalize it (it will have more than 6 parameters)
Indeed, I falsely assumed that num_threads required an ICE.
Please add a test that actually involves a contextual conversion then.
http://llvm-reviews.chandlerc.com/D2964
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
