On Mar 5, 2014, at 9:29 AM, Jordan Rose <[email protected]> wrote:
>
>
> On Mar 4, 2014, at 22:47 , Argyrios Kyrtzidis <[email protected]> wrote:
>
>> - if (!T->isObjCIdType() && !T->isObjCQualifiedIdType()) {
>> + if (!T->isObjCIdType() && !T->isObjCQualifiedIdType() &&
>> + !T->isObjCClassType() && !T->isObjCQualifiedClassType() &&
>> + !T->isObjCSelType()) {
>
> SEL isn't an ObjCObjectPointer. (It's an opaque pointer type, but not to an
> object.)
There’s a check and logic for T->isObjCSelType() earlier in the function so I’m
not sure if it’s dead code or not.
>
> Is it worth adding test cases like this? (Not that I've ever seen code like
> this, but it is legal...)
>
>> typedef NSObject MyObject;
>> typedef NSObject *MyObjectRef;
>>
>> MyObject <NSObject> *foo;
>> MyObjectRef bar;
>
Added test cases in r202995; for "MyObject <NSObject> *” it doesn’t preserve
the typedef name so I added a FIXME.
Thanks for reviewing!_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
