On Wed, Mar 5, 2014 at 5:14 PM, Richard Smith <[email protected]> wrote: > On 5 Mar 2014 14:11, "Aaron Ballman" <[email protected]> wrote: >> >> On Wed, Mar 5, 2014 at 5:09 PM, Richard Smith <[email protected]> >> wrote: >> > On 5 Mar 2014 14:06, "Aaron Ballman" <[email protected]> wrote: >> >> >> >> Author: aaronballman >> >> Date: Wed Mar 5 15:59:02 2014 >> >> New Revision: 203014 >> >> >> >> URL: http://llvm.org/viewvc/llvm-project?rev=203014&view=rev >> >> Log: >> >> Updating this test case to appease build bots which support ANSI escape >> >> sequences (unlike my dev box). >> >> >> >> Modified: >> >> cfe/trunk/test/Misc/ast-dump-color.cpp >> >> >> >> Modified: cfe/trunk/test/Misc/ast-dump-color.cpp >> >> URL: >> >> >> >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Misc/ast-dump-color.cpp?rev=203014&r1=203013&r2=203014&view=diff >> >> >> >> >> >> ============================================================================== >> >> --- cfe/trunk/test/Misc/ast-dump-color.cpp (original) >> >> +++ cfe/trunk/test/Misc/ast-dump-color.cpp Wed Mar 5 15:59:02 2014 >> >> @@ -59,7 +59,7 @@ int TestExpr __attribute__((guarded_by(m >> >> //CHECK: {{^}}[[Blue]]| >> >> `-[[RESET]][[YELLOW]]ParagraphComment[[RESET]][[Yellow]] >> >> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]col:4[[RESET]], >> >> [[Yellow]]col:11[[RESET]]>{{$}} >> >> //CHECK: {{^}}[[Blue]]| >> >> `-[[RESET]][[YELLOW]]TextComment[[RESET]][[Yellow]] >> >> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]col:4[[RESET]], >> >> [[Yellow]]col:11[[RESET]]> Text=" Comment"{{$}} >> >> //CHECK: >> >> {{^}}[[Blue]]|-[[RESET]][[GREEN]]CXXRecordDecl[[RESET]][[Yellow]] >> >> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:1[[RESET]], >> >> [[Yellow]]line:25:1[[RESET]]> class[[CYAN]] Mutex[[RESET]] >> >> definition{{$}} >> >> -//CHECK: {{^}}[[Blue]]| >> >> |-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]] >> >> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability >> >> ""{{$}} >> >> +//CHECK: {{^}}[[Blue]]| >> >> |-[[RESET]][[BLUE]]CapabilityAttr[[RESET]][[Yellow]] >> >> 0x{{[0-9a-fA-F]*}}[[RESET]] <[[Yellow]]line:18:22[[RESET]]> capability >> >> "mutex"{{$}} >> > >> > Huh? How do ANSI color sequences affect whether this line ends "" or >> > "mutex"? >> >> They don't -- I'm merely muttering that this test never runs for me on >> my Windows box, so I always seem to break it and only find out by >> annoying the build bots. > > Ah, I see. Can we improve this test to also cope with the various [[things]] > expanding to empty strings, so we can enable it unconditionally?
Uncertain, but definitely worth me spending some time looking into. ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
