The test in the clang patch passes without the rest of the patch. I think you need to add a check that -no-integrated-as isn't present in the sub-command. Other than that it LGTM. I'm happy to commit it for you once you've fixed that bug.
> -----Original Message----- > From: Brad Smith [mailto:[email protected]] > Sent: 07 March 2014 09:50 > To: Daniel Sanders > Cc: llvm cfe > Subject: Re: [PATCH] Use the integrated assembler by default on > OpenBSD/powerpc > > On 04/03/14 9:08 PM, Brad Smith wrote: > > On Tue, Mar 04, 2014 at 01:33:48PM +0000, Daniel Sanders wrote: > >> You'll find four 'UseIntegratedAssembler = true;' statements in > >> lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp, one in each > MCAsmInfo > >> subclass. These enable the integrated assembler by default for X86. > >> There are similar statements in other subclasses of MCAsmInfo. > >> > >> The PowerPC version of this code (in PPCMCAsmInfo.cpp) currently > >> looks like this: > >> if (T.getOS() == llvm::Triple::FreeBSD || > >> (T.getOS() == llvm::Triple::NetBSD && !is64Bit)) > >> UseIntegratedAssembler = true; > > > > Thank you for pointing that out. I have submitted a patch to the LLVM > > list. > > The LLVM patch was commited. Please commit this patch. > > > -- > This message has been scanned for viruses and dangerous content by > MailScanner, and is believed to be clean. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
