LGTM
================ Comment at: lib/Driver/Tools.cpp:1780 @@ +1779,3 @@ + StringRef OSLibName = Triple.getOS() == llvm::Triple::FreeBSD ? + Triple.getOSTypeName(Triple.getOS()) : TC.getOS(); + llvm::sys::path::append(Res, "lib", OSLibName); ---------------- Yes, please use explicit "freebsd" for now (and leave a comment why you're doing this). ================ Comment at: lib/Driver/Tools.cpp:1843 @@ -1840,2 +1842,3 @@ CmdArgs.push_back("-lm"); + // There's no libdl on FreeBSD. ---------------- Remove newline here. http://llvm-reviews.chandlerc.com/D2644 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits