I think that this generally looks good. I still have a concern about the names: we generate names like __context. Now I understand that a user should not generate names like this, but what if they do? Does it crash? We need to make sure that have reasonable error detection and reporting for these things. In the clang-omp branch the names are generated with a preceding ''.' -- ".__kmpc_global_thread_num." for example -- and this can never conflict with a user-provided identifier. This seems safer, so why are you not doing that here?
http://llvm-reviews.chandlerc.com/D2883 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
