Hi Diego, I prefer not to comment on the front-end part, I do not know it well enough. I think Richard and Eric's comments do the trick :).
For the diagnostic handler, the way we handle it seems a bit odd. See my inline comment. Thanks, -Quentin ================ Comment at: lib/CodeGen/CodeGenAction.cpp:419 @@ -394,1 +418,3 @@ + OptimizationReportHandler(cast<DiagnosticInfoOptimizationReport>(DI)); + return; default: ---------------- This does not follow the same pattern as the previous handler, i.e., with the fall through setting the DiagID to use the default handler (the ComputeDiagID part etc.). My guess is we want to push the check of CodeGenOpts.OptimizationReportPattern into OptimizationReportHandler and check the return of that. If we do not want to follow the same pattern, we should comment on that. Indeed, I think it is important to explain why we are not reporting anything when CodeGenOpts.OptimizationReportPattern is not set. http://llvm-reviews.chandlerc.com/D3226 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
