On Thu, Apr 3, 2014 at 7:47 PM, Alexey Bataev <[email protected]> wrote:
> Hi Richard, > Thanks for review. > But I made this changes just to be fully compatible with the previous one > made by Aaron Ballman (see changes in revision 203937). > Yes, those are bad names too. Feel free to fix them all =) > Best regards, > Alexey Bataev > ============= > Software Engineer > Intel Compiler Team > Intel Corp. > > 3 Апрель 2014 г. 22:04:27, Richard Smith писал: > >> On Wed, Apr 2, 2014 at 7:55 PM, Alexey Bataev <[email protected] >> <mailto:[email protected]>> wrote: >> >> Author: abataev >> Date: Wed Apr 2 21:55:46 2014 >> New Revision: 205506 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=205506&view=rev >> Log: >> [OPENMP] Small update for C++11 >> >> Modified: >> cfe/trunk/lib/Sema/TreeTransform.h >> cfe/trunk/lib/Serialization/ASTWriterStmt.cpp >> >> Modified: cfe/trunk/lib/Sema/TreeTransform.h >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/ >> TreeTransform.h?rev=205506&r1=205505&r2=205506&view=diff >> ============================================================ >> ================== >> --- cfe/trunk/lib/Sema/TreeTransform.h (original) >> +++ cfe/trunk/lib/Sema/TreeTransform.h Wed Apr 2 21:55:46 2014 >> @@ -6439,10 +6439,8 @@ OMPClause * >> TreeTransform<Derived>::TransformOMPCopyinClause(OMPCopyinClause >> *C) { >> llvm::SmallVector<Expr *, 16> Vars; >> Vars.reserve(C->varlist_size()); >> - for (OMPCopyinClause::varlist_iterator I = C->varlist_begin(), >> - E = C->varlist_end(); >> - I != E; ++I) { >> - ExprResult EVar = getDerived().TransformExpr(cast<Expr>(*I)); >> + for (auto *I : C->varlists()) { >> >> >> This is not an iterator, so should not be named I. >> >> + ExprResult EVar = getDerived().TransformExpr(cast<Expr>(I)); >> if (EVar.isInvalid()) >> return 0; >> Vars.push_back(EVar.take()); >> >> Modified: cfe/trunk/lib/Serialization/ASTWriterStmt.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ >> Serialization/ASTWriterStmt.cpp?rev=205506&r1=205505&r2=205506&view=diff >> ============================================================ >> ================== >> --- cfe/trunk/lib/Serialization/ASTWriterStmt.cpp (original) >> +++ cfe/trunk/lib/Serialization/ASTWriterStmt.cpp Wed Apr 2 >> 21:55:46 2014 >> @@ -1719,10 +1719,8 @@ void OMPClauseWriter::VisitOMPSharedClau >> void OMPClauseWriter::VisitOMPCopyinClause(OMPCopyinClause *C) { >> Record.push_back(C->varlist_size()); >> Writer->Writer.AddSourceLocation(C->getLParenLoc(), Record); >> - for (OMPCopyinClause::varlist_iterator I = C->varlist_begin(), >> - E = C->varlist_end(); >> - I != E; ++I) >> - Writer->Writer.AddStmt(*I); >> + for (auto *I : C->varlists()) >> >> >> Likewise. >> >> + Writer->Writer.AddStmt(I); >> } >> >> //===------------------------------------------------------- >> ---------------===// >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] <mailto:[email protected]> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> >>
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
