IntrusiveRefCntPtr<LangOptions> LangOpts;
IntrusiveRefCntPtr<DiagnosticsEngine> Diagnostics;
+ IntrusiveRefCntPtr<vfs::FileSystem> VFS;
IntrusiveRefCntPtr<FileManager> FileMgr;
IntrusiveRefCntPtr<SourceManager> SourceMgr;
<…>
DiagnosticsEngine &Diag, LangOptions &LangOpts,
SourceManager &SourceMgr, FileManager &FileMgr,
+ vfs::FileSystem &VFS,
Why do we need to keep the VFS separately, isn’t it owned by the FileManager ?
Would it be better if a
IntrusiveRefCntPtr<vfs::FileSystem> FS;
is part of FileSystemOptions ? And created at the time with get the
FileSystemOptions for the compiler invocation ?
It seems it would simplify a bunch of code.
On Apr 11, 2014, at 2:14 PM, Ben Langmuir <[email protected]> wrote:
> Hi Dmitri and Argyrios,
>
> Could one (or both) of you take a look at my changes to the ASTUnit to
> support the VFS? The VFS needs to be created for most/all of the FileManagers
> that get created, and I’m a bit worried by the sheer number of FileManager
> and SourceManager creations that I needed to plug up.
>
> Ben
>
> <astunit.patch>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
