Committed in r206302, and the test in r206303.
On Mon, Apr 14, 2014 at 5:41 PM, Manjunath Kudlur <[email protected]> wrote: > > > ================ > Comment at: lib/CodeGen/TargetInfo.cpp:4770 > @@ -4768,1 +4769,3 @@ > + static void addNVVMMetadata(llvm::Function *F, StringRef Name, > + const int Operand); > }; > ---------------- > Reid Kleckner wrote: > > Having const ints feels silly, since the caller really doesn't care. > const removed. > > ================ > Comment at: lib/CodeGen/TargetInfo.cpp:4848 > @@ +4847,3 @@ > + addNVVMMetadata(F, "maxntidx", > + > FD->getAttr<CUDALaunchBoundsAttr>()->getMaxThreads()); > + // min blocks is a default argument for CUDALaunchBoundsAttr, so > getting a > ---------------- > Reid Kleckner wrote: > > nit: indentation > Fixed. > > ================ > Comment at: lib/CodeGen/TargetInfo.cpp:4853 > @@ +4852,3 @@ > + // don't have to add a PTX directive. > + int minctasm = FD->getAttr<CUDALaunchBoundsAttr>()->getMinBlocks(); > + if (minctasm > 0) { > ---------------- > Reid Kleckner wrote: > > The naming for local variables is StudlyCaps. > Fixed. > > > http://reviews.llvm.org/D3318 > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
