On Wed, Apr 23, 2014 at 8:21 AM, Diego Novillo <[email protected]> wrote: > Author: dnovillo > Date: Wed Apr 23 10:21:23 2014 > New Revision: 206997 > > URL: http://llvm.org/viewvc/llvm-project?rev=206997&view=rev > Log: > Review feedback.
It's useful to mention what the actual change is (even if it's something simple like "correct grammar") on the first line of the commit message. Then I usually put "Code review feedback from rXXXX by John Smith" after a blank line, so people can search for the revision number and find the original commit/code review feedback/context/etc. > > Modified: > cfe/trunk/docs/UsersManual.rst > > Modified: cfe/trunk/docs/UsersManual.rst > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UsersManual.rst?rev=206997&r1=206996&r2=206997&view=diff > ============================================================================== > --- cfe/trunk/docs/UsersManual.rst (original) > +++ cfe/trunk/docs/UsersManual.rst Wed Apr 23 10:21:23 2014 > @@ -1123,7 +1123,7 @@ usual build cycle when using sample prof > > $ create_llvm_prof --binary=./code --out=code.prof > > - This will read ``perf.data``, the binary file ``./code`` and emit > + This will read ``perf.data`` and the binary file ``./code`` and emit > the profile data in ``code.prof``. Note that if you ran ``perf`` > without the ``-b`` flag, you need to use ``--use_lbr=false`` when > calling ``create_llvm_prof``. > @@ -1160,7 +1160,7 @@ https://github.com/google/autofdo/blob/m > ... > offsetN[.discriminator]: number_of_samples [fn5:num fn6:num ... ] > > -The file may contain blank lines between sections and lines within a > +The file may contain blank lines between sections and within a > section. However, the spacing within a single line is fixed. Additional > spaces will result in an error while reading the file. > > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
