Any chance this could be applied?
On Thu, Mar 20, 2014 at 10:57 PM, Keno Fischer <[email protected] > wrote: > I had a look, but I don't think I have a way to write a reasonably small > test case and there isn't much there in terms of setting up the rest of the > compiler to be able to test this one issue. > > > On Wed, Mar 19, 2014 at 4:41 PM, David Blaikie <[email protected]> wrote: > >> On Wed, Mar 19, 2014 at 11:53 AM, Keno Fischer >> <[email protected]> wrote: >> > I'm not sure I can come up with a reasonably well isolated test case. I >> > encountered this in an application that uses clang as a library. From >> what I >> > can see most of the test cases use the clang driver to test for bugs. Is >> > there any examples of test cases that go through the C++ API (since I >> know >> > how to trigger it there)? >> >> The unit tests provide API level testing - tools/clang/unittests. >> Though not all API surface is readily unit testable and we'll usually >> allow an untested change if there's just no accessible test point... >> as unfortunate as it is and as much as we'd like that to change. >> >> > >> > >> > On Wed, Mar 19, 2014 at 11:07 AM, David Blaikie <[email protected]> >> wrote: >> >> >> >> A test case would be good, if possible >> >> >> >> On Tue, Mar 18, 2014 at 9:44 PM, Keno Fischer >> >> <[email protected]> wrote: >> >> > Sema::ConvertArgumentsForCall calls setNumArgs on the CallExpr. This >> >> > changes >> >> > the result of getLocStart if the SourceLocation stored in the >> CallExpr >> >> > is >> >> > invalid and in that case may lead to an assertion failure. This quick >> >> > patch >> >> > fixes that. >> >> > >> >> > I don't have commit access so let me know if anything else is needed. >> >> > >> >> > _______________________________________________ >> >> > cfe-commits mailing list >> >> > [email protected] >> >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> > >> > >> > >> > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
