On Wed, Apr 23, 2014 at 10:16 PM, Nico Weber <[email protected]> wrote:

> +        if (DidSetDeprecatedMessage)
> +          clang_disposeString(*deprecated_message);
>          *deprecated_message =
> cxstring::createDup(Deprecated->getMessage());
> +        DidSetDeprecatedMessage = true;
>

Can we really not tell that the message doesn't hold a string to dispose
of? Maybe even better, have clang_disposeString just no-op in that case
(the way free, delete, etc do)?
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to