Are you sure this is correct? One worklist treats the entry block as already analyzed, the other doesn't. One starts with no blocks enqueued, the other effectively has all blocks enqueued because of the iterators.
Small comments: - Why doesn't enqueueSuccessors use enqueueBlock? - Since this is only used by classes in the same component of Clang, it might make sense to put even the header in the lib/ directory. That way it doesn't show up when other people build tools on top of Clang. Then again, it is a generally reusable component. Jordan On Apr 25, 2014, at 7:53 , Artyom Skrobov <[email protected]> wrote: > Hello, > > LiveVariables and UninitializedValues analyses had slightly different > implementations of DataflowWorklist, both by Ted Kremenek in 2011. > > The two variants of DataflowWorklist had similar (though not identical) > interfaces, and apparently both were used for similar purposes. > > My patch is to factor this class out of those two analyses. No functional > change intended. > > Is it OK? > > <DataflowWorklist.patch>_______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
