On 28/04/2014 11:11, Tobias Grosser wrote:
CXDiagnostic with value 5 is higher than CXDiagnostic_Error and there
are many applications using the outlined pattern that break following
the change, either by crashing or mis-categorising diagnostics as fatal
errors.
I see that the above categorizes the diagnostic as an error. This is
obviously incorrect.
Strongly disagree. The ordering of this enum is significant and
explicitly tested for. The test ensures that you can take an application
built against any previous version of clang and run it against a newer
release or ToT -- which would no longer be the case with your change.
I agree the enum wasn't particularly future-proof but it's not feasible
to change it now.
Alp.
--
http://www.nuanti.com
the browser experts
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
