Hi Rafael, On Tue, Apr 29, 2014 at 7:21 PM, Rafael Espíndola <[email protected]> wrote: > + #else > > + file_status(file_type Type) : Type(Type) {} > > This is never used, right? We always have windows or unix.
Good point. That #else could be removed. I noticed however that in "llvm/Support/Process.h", if the OS is neither Windows nor Linux, we #error with "Unsupported operating system.". Should I add #error in case of unsupported OS or do you prefer that I remove the #else entirely? > > > While you are at it, would you mind also updating the default constructor? Sure, I will fix the default constructor. > > > Do we also crash in some llvm tools like llvm-as? That would allow us > to test directly from llvm. Unfortunately I am only able to reproduce the assertion failure with clang.. I just finished testing llvm-as, llvm-dis, llc and opt; none of those tools crash for me. Andrea > > LGTM with those changes. > > Cheers, > Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
