On Tue, Apr 29, 2014 at 1:17 PM, Arnaud Allard de Grandmaison <
[email protected]> wrote:
> In clang/lib/Tooling/CompilationDatabase.cpp:241, this really looks weird:
>
> // Remove -no-integrated-as; it's not used for syntax checking,
> // and it confuses targets which don't support this option.
> std::remove_if(Args.begin(), Args.end(),
> MatchesAny(std::string("-no-integrated-as")));
>
> The attached patch adds the extra erase step necessary to really remove
> the elements --- as the comment states. But it bothers me to see that the
> current code seems to work as it is, hinting that those lines may no longer
> be necessary.
>
I don't see how those lines work as is. I think they are only working in
the absence of that flag.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
