On Fri, May 2, 2014 at 8:45 PM, Alp Toker <[email protected]> wrote: > Fix a bunch of mislayered clang/Lex includes from Sema
The direction of this change makes lots of sense, but this commit log isn't really helpful for reviewers because you're actually making non-trivial changes in order to fix the layering issues. It would be really helpful for me at least to both split each change into its own commit unless they are interdependent in some way, and to describe the nature of the layering fix when it isn't just a "include the right header instead of the wrong header".
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
