Committed in r193743 (and later fixes in r194440 r194422 r194081 r194079
r193842 r193841 r193746).
================
Comment at: pp-trace/PPCallbacksTracker.cpp:81
@@ +80,3 @@
+// Mapping strings.
+static const char *MappingStrings[] = { "0", "MAP_IGNORE",
+ "MAP_WARNING", "MAP_ERROR",
----------------
Kim Gräsman wrote:
> Indentation looks funny here, but maybe that's a good thing considering that
> "0" is apparently not in the enum. :-)
The comment of the Mapping enum mentions value of 0 meaning "uncomputed".
Indentation courtesy of clang-format:-)
================
Comment at: pp-trace/PPCallbacksTracker.cpp:101
@@ +100,3 @@
+
+// Callback invoked whenever a source file is entered or exited.
+void PPCallbacksTracker::FileChanged(
----------------
Kim Gräsman wrote:
> Should these be doxygen comments?
Sean pointed out that since these are overrides, they shouldn't have the
Doxygen comments.
http://reviews.llvm.org/D2020
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
