Seems consistent with what MSVC does. I'd change the wording of the warning to match our other extension warnings. Something like: "... (is|are|as) a Microsoft extension"
Otherwise, looks good. On Wed, May 7, 2014 at 9:58 AM, Will Wilson <[email protected]> wrote: > Now with added patch... > > > On 7 May 2014 18:57, Will Wilson <[email protected]> wrote: > >> Hi All, >> >> Here's a small patch to allow duplicate explicit class instantiations >> through with only a warning in MSVCCompat mode. MSVC itself silently >> ignores duplicate explicit instantiations. Clang appears to skip any >> duplicates so it shouldn't be too much of an issue to reduce the error to a >> warning for MSVC compatibility in this case. >> >> Test case included and clang format applied. Let me know if it LGTY. >> >> Cheers, >> Will. >> > > > > -- > *Indefiant *: http://www.indefiant.com > Home of Recode : Runtime C++ Editing for VS >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
