On Thu, May 8, 2014 at 1:20 PM, Richard Smith <[email protected]> wrote:
> On Thu, May 8, 2014 at 11:09 AM, Ben Langmuir <[email protected]> wrote: > >> Author: benlangmuir >> Date: Thu May 8 13:09:29 2014 >> New Revision: 208345 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=208345&view=rev >> Log: >> Remove -Wnon-modular-include >> >> But keep -Wnon-modular-include-in-[framework-]module >> >> This warning is too noisy and doesn't really indicate a problem for most >> people. Even though it would only really affect people using >> -Weverything, that seems bad so remove it. >> > > Wait a second, we were planning on using this to replace > -fmodules-strict-decluse. People using -Weverything need to use -Wno-foo > for the warnings they don't want; that's the cost of using that option. > >From when -Weverything was added: Eli Friedman wrote: > This seems like a bad idea: people will start using it, then complain > whenever we add a new warning which isn't generically applicable > (suppose we add an opt-in warning for C-style casts in C++, for > example). We already have -Wextra for people who want lots of> warnings. Ted Kremenek responded: [...] > -Weverything is not for everybody, and for those that complain about > new warnings we can (and should) tell them to take the opt-in approach > as opposed to the opt-out approach. I don't see a problem with really > serving both sets of user preferences. => We do not get to use -Weverything as an excuse for removing warning that are noisy and that some users aren't interested in.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
