Compelling argument. I just went with "let's fix this test" without looking at it more closely.
I'll get it since I've still got it up in my editor. -eric On Tue, May 13, 2014 at 1:06 PM, Rafael Avila de Espindola <[email protected]> wrote: > Why can't this just check that the driver passes the correct flag to -cc1? > > Sent from my iPhone > >> On May 13, 2014, at 15:52, Eric Christopher <[email protected]> wrote: >> >> Author: echristo >> Date: Tue May 13 14:52:18 2014 >> New Revision: 208722 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=208722&view=rev >> Log: >> Add a requires for the arm-registered-target needed by this test as >> well. >> >> Modified: >> cfe/trunk/test/Driver/masm.c >> >> Modified: cfe/trunk/test/Driver/masm.c >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/masm.c?rev=208722&r1=208721&r2=208722&view=diff >> ============================================================================== >> --- cfe/trunk/test/Driver/masm.c (original) >> +++ cfe/trunk/test/Driver/masm.c Tue May 13 14:52:18 2014 >> @@ -2,11 +2,12 @@ >> // RUN: %clang -target i386-unknown-linux -masm=intel %s -S -o - | FileCheck >> --check-prefix=CHECK-INTEL %s >> // RUN: %clang -target i386-unknown-linux -masm=att %s -S -o - | FileCheck >> --check-prefix=CHECK-ATT %s >> // RUN: not %clang -target i386-unknown-linux -masm=somerequired %s -S -o - >> 2>&1 | FileCheck --check-prefix=CHECK-SOMEREQUIRED %s >> +// REQUIRES: arm-registered-target >> // RUN: %clang -target arm-unknown-eabi -masm=intel %s -S -o - 2>&1 | >> FileCheck --check-prefix=CHECK-ARM %s >> >> int f() { >> -// CHECK-ATT: movl $0, %eax >> -// CHECK-INTEL: mov eax, 0 >> +// CHECK-ATT: movl $0, %eax >> +// CHECK-INTEL: mov eax, 0 >> // CHECK-SOMEREQUIRED: error: unsupported argument 'somerequired' to option >> 'masm=' >> // CHECK-ARM: warning: argument unused during compilation: '-masm=intel' >> return 0; >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
