LGTM with a comment

================
Comment at: lib/AST/ASTContext.cpp:7802
@@ +7801,3 @@
+static GVALinkage fixGVALinkageForDLLAttribute(GVALinkage L, const Decl *D) {
+  if (D->hasAttr<DLLImportAttr>()) {
+    if (L == GVA_DiscardableODR || L == GVA_StrongODR)
----------------
This should have a comment about the semantics of dllimport and dllexport, and 
link to the MSDN doc on dllexport with inline functions:
http://msdn.microsoft.com/en-us/library/xa0d9ste.aspx

http://reviews.llvm.org/D3772



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to