On Thu, May 22, 2014 at 5:15 PM, David Blaikie <[email protected]> wrote:
> On Thu, May 22, 2014 at 4:54 AM, Daniel Jasper <[email protected]> wrote: > > As there was no objection by now, I assume this is acceptable. > > It's generally considered poor form to submit code you've sent review > when you haven't received that review... it creates a difficult > situation where people may feel it acceptable to submit due to long > review turnaround which isn't something we want to encourage in the > community. > And you think me and the reviewer sitting right next to me can't figure this out ... If you send something for review, it's presumed to be because you > don't feel confident that it's the right change and need a second set > of eyes to confirm/discuss that with - time shouldn't change that. > > - David > > > > > http://reviews.llvm.org/D418 > > > > > > > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
