On Mon, Jun 2, 2014 at 2:13 PM, Nico Weber <[email protected]> wrote:
> On Mon, Jun 2, 2014 at 2:00 PM, Nico Weber <[email protected]> wrote: > >> Author: nico >> Date: Mon Jun 2 07:00:08 2014 >> New Revision: 210019 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=210019&view=rev >> Log: >> Remove unused code in a libc++ test. >> >> Other tests in this directory use this type, so it's probably copypasta >> from >> there. >> >> (test_buf only forwards to the superclass in all tests where it's used >> though, >> so I wonder if it can be replaced with just using filebuf / wfilebuf >> everywhere?) >> > > No: test_buf isn't unused, it's used to make protected members such > as pbackfail() public for testing. So it needs to stay around in the other > tests. > (Since this sounds confusing: r210019 is a good change, but it's not possible to do the same change in more tests like I idly wondered in the commit message.)
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
