I wasn't aware of the script but renaming the namespace did cross my mind. I thought it'd be silly to just swap the comment and namespace and decided against it :)
Renamed in r210080 On Tue, Jun 3, 2014 at 4:36 PM, Richard Smith <[email protected]> wrote: > On Mon, Jun 2, 2014 at 7:57 PM, Nikola Smiljanic <[email protected]> > wrote: > >> Author: nikola >> Date: Mon Jun 2 21:56:59 2014 >> New Revision: 210064 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=210064&view=rev >> Log: >> Move DR532 test where it belongs. >> >> Modified: >> cfe/trunk/test/CXX/drs/dr5xx.cpp >> cfe/trunk/test/CXX/temp/temp.decls/temp.fct/temp.func.order/p3.cpp >> >> Modified: cfe/trunk/test/CXX/drs/dr5xx.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/drs/dr5xx.cpp?rev=210064&r1=210063&r2=210064&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CXX/drs/dr5xx.cpp (original) >> +++ cfe/trunk/test/CXX/drs/dr5xx.cpp Mon Jun 2 21:56:59 2014 >> @@ -194,3 +194,19 @@ namespace dr525 { // dr525: yes >> } >> } >> } >> + >> +// Core DR 532. >> +namespace PR8130 { >> > > We have a special convention for tests in this directory: name the > namespace after the core issue (namespace dr532) and add a comment "// > dr532: 3.5" to indicate that the issue was implemented in Clang 3.5. A > script then scrapes this information to produce the cxx_dr_status.html page > on the website. > > >> + struct A { }; >> + >> + template<class T> struct B { >> + template<class R> int &operator*(R&); >> + }; >> + >> + template<class T, class R> float &operator*(T&, R&); >> + void test() { >> + A a; >> + B<A> b; >> + int &ir = b * a; >> + } >> +} >> >> Modified: >> cfe/trunk/test/CXX/temp/temp.decls/temp.fct/temp.func.order/p3.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/temp/temp.decls/temp.fct/temp.func.order/p3.cpp?rev=210064&r1=210063&r2=210064&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CXX/temp/temp.decls/temp.fct/temp.func.order/p3.cpp >> (original) >> +++ cfe/trunk/test/CXX/temp/temp.decls/temp.fct/temp.func.order/p3.cpp >> Mon Jun 2 21:56:59 2014 >> @@ -2,22 +2,6 @@ >> // RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s >> // expected-no-diagnostics >> >> -// Core DR 532. >> -namespace PR8130 { >> - struct A { }; >> - >> - template<class T> struct B { >> - template<class R> int &operator*(R&); >> - }; >> - >> - template<class T, class R> float &operator*(T&, R&); >> - void test() { >> - A a; >> - B<A> b; >> - int &ir = b * a; >> - } >> -} >> - >> namespace OrderWithStaticMember { >> struct A { >> template<class T> int g(T**, int=0) { return 0; } >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
