On Wed, Jun 4, 2014 at 7:57 PM, Tyler Nowicki <[email protected]> wrote:
> Hi Aaron and Richard, > > Thanks for the review and putting up with me while I learn clang! Here is > the patch with your changes. > > > >> + // Vectorization/interleaving is disabled, set width/count to 1. > >> + ValueInt = 1; > >> + // Fallthrough. > > > > We should add [[clang::fallthrough]] to Compiler.h and use it here. :-) > > Turns out I didn’t need to make any changes to Compiler.h. It works fine > for me. Will it work for all builds? > Unlikely. MSVC's table of C++11 lists attributes as unsupported: http://msdn.microsoft.com/en-us/library/hh567368.aspx GCC is also likely to warn on unrecognized attributes, which wouldn't work.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
