On Thu, Jun 5, 2014 at 3:11 PM, Alp Toker <[email protected]> wrote: > Author: alp > Date: Thu Jun 5 17:11:20 2014 > New Revision: 210295 > > URL: http://llvm.org/viewvc/llvm-project?rev=210295&view=rev > Log: > Remove old proposal notices > > Let's just go ahead and assume the answer was 'I do' >
:) You can check what proposals have made it into the ABI here: http://mentorembedded.github.io/cxx-abi/abi.html For the ones that aren't in the ABI, having a comment explaining why we're using them and where they come from is useful. None of these three are in the ABI document yet; please back this out for now. John: any chance we could get the ABI document updated with these? ( http://sourcerytools.com/pipermail/cxx-abi-dev/2012-January/000024.html) Modified: > cfe/trunk/lib/AST/ItaniumMangle.cpp > cfe/trunk/test/CodeGenCXX/mangle-template.cpp > > Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ItaniumMangle.cpp?rev=210295&r1=210294&r2=210295&view=diff > > ============================================================================== > --- cfe/trunk/lib/AST/ItaniumMangle.cpp (original) > +++ cfe/trunk/lib/AST/ItaniumMangle.cpp Thu Jun 5 17:11:20 2014 > @@ -2674,7 +2674,6 @@ recurse: > llvm_unreachable("cannot mangle opaque value; mangling wrong thing?"); > > case Expr::InitListExprClass: { > - // Proposal by Jason Merrill, 2012-01-03 > Out << "il"; > const InitListExpr *InitList = cast<InitListExpr>(E); > for (unsigned i = 0, e = InitList->getNumInits(); i != e; ++i) > @@ -2739,7 +2738,6 @@ recurse: > Out << '_'; > mangleType(New->getAllocatedType()); > if (New->hasInitializer()) { > - // Proposal by Jason Merrill, 2012-01-03 > if (New->getInitializationStyle() == CXXNewExpr::ListInit) > Out << "il"; > else > @@ -2825,7 +2823,6 @@ recurse: > const CXXConstructExpr *CE = cast<CXXConstructExpr>(E); > unsigned N = CE->getNumArgs(); > > - // Proposal by Jason Merrill, 2012-01-03 > if (CE->isListInitialization()) > Out << "tl"; > else > > Modified: cfe/trunk/test/CodeGenCXX/mangle-template.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-template.cpp?rev=210295&r1=210294&r2=210295&view=diff > > ============================================================================== > --- cfe/trunk/test/CodeGenCXX/mangle-template.cpp (original) > +++ cfe/trunk/test/CodeGenCXX/mangle-template.cpp Thu Jun 5 17:11:20 2014 > @@ -147,7 +147,7 @@ namespace test10 { > } > } > > -// Report from Jason Merrill on cxx-abi-dev, 2012.01.04. > +// Report from cxx-abi-dev, 2012.01.04. > namespace test11 { > int cmp(char a, char b); > template <typename T, int (*cmp)(T, T)> struct A {}; > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
