Thanks, this looks much nicer.

================
Comment at: lib/Parse/ParseTemplate.cpp:503
@@ +502,3 @@
+  if (TryConsumeToken(tok::ellipsis, EllipsisLoc))
+    DiagnoseMisplacedEllipsis(EllipsisLoc, NameLoc, false, true);
+
----------------
I don't think your `AlreadyHasEllipsis` argument here is correct; we might have 
parsed one a few lines above.

================
Comment at: lib/Parse/ParseTemplate.cpp:588
@@ +587,3 @@
+  if (TryConsumeToken(tok::ellipsis, EllipsisLoc))
+    DiagnoseMisplacedEllipsis(EllipsisLoc, NameLoc, false, true);
+
----------------
Likewise here.

http://reviews.llvm.org/D3604



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to