On Thu, Jun 5, 2014 at 10:17 PM, Tyler Nowicki <[email protected]> wrote: > Hi Aaron, > > Thanks for the review! > > I’ve made the changes you suggested except for adding the tests. I mighty be > mistaken, but don’t the tests in the first patch test/PCH/pragma-loop.cpp and > test/Parser/pragma-loop-ast.cpp verify that pretty printing is outputting the > correct pragma? Is there another place for tests specific to pretty printing?
PCH tests that serialization and unserialization work. AST tests that the AST representation has the correct information. What I was looking for was something akin to test/Sema/attr-print.c where you use -ast-print, which exercises the pretty printing functionality to make sure that the new printing functionality works as expected. Aside from the test, LGTM! If you need me to commit for you, I'd appreciate if you would rebase off ToT (I get merge conflicts currently). Thanks! ~Aaron _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
