Hi Alp, Awesome, thanks! I thought my second message included the DataRecursiveASTVisitor, didn't it? Anyway, the update is trivial.
I have got two more patches on the same file(s) :) Let me send this in separate emails. -- Mathieu 2014-06-06 8:14 GMT-07:00 Alp Toker <[email protected]>: > On 02/06/2014 03:46, Mathieu Baudet wrote: >> >> Hi, >> >> Is there anything else I can do to help land this fix? > > > Hi Mathieu > > It looks good. I've gone ahead and landed this in r210339.. > > In the commit I've additionally applied the change into > DataRecursiveASTVisitor because we're converging the two copies -- AFAICT > it'll be overridden in the latter case by handlers that know more about > Objective-C declarations so should be a no-op for libclang (which is what we > want). > > Thanks for holding! > > Alp. > > > >> >> -- Mathieu >> >> 2014-05-22 10:15 GMT-07:00 Mathieu Baudet <[email protected]>: >>> >>> Thanks for your feedback. Here is an updated patch. >>> >>> -- Mathieu >>> >>> 2014-05-21 20:37 GMT-07:00 Jordan Rose <[email protected]>: >>>> >>>> This seems reasonable to me, but I'd appreciate it if someone more >>>> familiar with RAV took a look. Also, this should probably be applied to the >>>> DataRecursiveASTVisitor too, at least until the merge is complete. >>>> >>>> Jordan >>>> >>>> >>>> On May 20, 2014, at 18:59 , Mathieu Baudet <[email protected]> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> I made the patch in attachment. >>>>> >>>>> Hoping it is useful, >>>>> -- Mathieu >>>>> >>>>> <clang_RecursiveASTVisitor_VisitsObjCPropertyType.patch>_______________________________________________ >>>>> cfe-commits mailing list >>>>> [email protected] >>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > -- > http://www.nuanti.com > the browser experts > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
