----- Original Message ----- > From: "Jim Cownie" <[email protected]> > To: "a bataev" <[email protected]>, [email protected], [email protected], > [email protected], > [email protected], [email protected], [email protected] > Cc: "james h cownie" <[email protected]>, [email protected] > Sent: Monday, June 9, 2014 6:13:09 AM > Subject: Re: [PATCH] Using of variable length arrays in captured statements > and OpenMP constructs > > This looks very dubious > lib/CodeGen/CGStmt.cpp : 2076 > assert(CD->hasBody() && "missing CapturedDecl body"); > > I believe the "&&" should be a comma.
No, this looks fine (and follows the LLVM coding convention, see: http://llvm.org/docs/CodingStandards.html#assert-liberally). -Hal > > http://reviews.llvm.org/D4067 > > > -- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
