On Fri, Jun 13, 2014 at 1:54 AM, Nikola Smiljanić <[email protected]> wrote:
> Turns out we didn't have correct location and range for class template > friend. The same was true for case where friend is not the first token as > in Richard's inline example. > > Manuel: > Are my constructor/destructor matchers good? > At a first glance they make sense, yes... > > Richard: > 1. What's the TypeSourceInfo case in FriendDecl::getSourceRange? > 2. I couldn't find a way to hit the first call to FriendDecl::Create > inside Sema::ActOnTemplatedFriendTag (some kind of explicit specialization > case). I tried issuing a random diagnostic from there hoping it would break > something in the test suite but it seems we don't have any coverage for > this? > > http://reviews.llvm.org/D3906 > > Files: > include/clang/AST/DeclFriend.h > include/clang/Sema/Sema.h > lib/Sema/SemaDecl.cpp > lib/Sema/SemaDeclCXX.cpp > lib/Sema/SemaTemplate.cpp > unittests/AST/SourceLocationTest.cpp >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
