lgtm, with a few minor nits. Also, I'm assuming you compared the output with
cl?
================
Comment at: lib/CodeGen/MicrosoftRTTI.cpp:60
@@ +59,3 @@
+ llvm::Type *PtrType) {
+ if (!isImageRelative(CGM))
+ return PtrType;
----------------
is it more normal do do this this way or use
return isImageRelative(CGM) ? PtrType : CGM.IntTy;
?
================
Comment at: lib/CodeGen/MicrosoftRTTI.cpp:156
@@ +155,3 @@
+ };
+ llvm::ArrayRef<llvm::Type *> FieldTypesRef(FieldTypes);
+ if (!isImageRelative(CGM))
----------------
I assume ArrayRef can take a pointer and a size. If so I think it would be
more reasonable to adjust the input size rather than slicing the result.
http://reviews.llvm.org/D4148
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
