Thanks. Also my patch up there was wrong anyway, so it all worked out in the end :)
On Thu, Jun 19, 2014 at 8:38 PM, Justin Bogner <[email protected]> wrote: > Justin Bogner <[email protected]> writes: > > Zachary Turner <[email protected]> writes: > >> This generates some crashes when running Windows tests. In particular, > this > >> asserts is being hit: > >> > >> assert(sys::path::is_absolute(VirtualPath) && "virtual path not > absolute"); > >> > >> inside the function void YAMLVFSWriter::addFileMapping(StringRef > VirtualPath, > >> StringRef RealPath) > >> > >> Inspecting VirtualPath in a debugger shows that the value is: > >> > >> > \\src\\llvm\\tools\\clang\\test\\Modules\\Inputs\\Module.framework\\Frameworks > >> \\SubFramework.framework\\Headers\\SubFramework.h > >> > >> The path qualified with drive letter on my machine that this resolves > to is > >> the aforementioned path prefixed with a D: > >> > >> So this should refer to a root path, but either way I'll leave it to > you to > >> decide whether the fix is to append the drive letter, or maybe the bug > is in > >> the is_absolute() function. > > > > The copyToRoot function is wrong here - It takes a shortcut in working > > out an absolute path that isn't valid on windows. I'll come up with a > > fix in a couple of hours. > > Should be fixed in r211338. >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
