AddressSanitizer.cpp LGTM
================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1069
@@ -1004,2 +1068,3 @@
GlobalVariable *G = GlobalsToChange[i];
+
PointerType *PtrTy = cast<PointerType>(G->getType());
----------------
nit: spare newline?
================
Comment at: projects/compiler-rt/test/asan/TestCases/global-location.cc:11
@@ +10,3 @@
+
+class C {
+ public:
----------------
"struct C", maybe?
================
Comment at: projects/compiler-rt/test/asan/TestCases/global-location.cc:17
@@ +16,3 @@
+int global[10];
+// GLOB: 0x{{.*}} is located 4 bytes to the right of global variable 'global'
defined in '{{.*}}/global-location.cc:[[@LINE-1]]:5' {{.*}} of size 40
+int C::array[10];
----------------
Do you need the slash before global-location.cc? Isn't it possible that
there's no directory prefix (maybe not in the current setup)?
http://reviews.llvm.org/D4203
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
