On Mon, Jun 23, 2014 at 4:30 PM, David Blaikie <[email protected]> wrote:
> Looks good - though I'd prefer to separate the discussion about column > info so as to isolate the changes/tests/etc and not delay this review. > > ================ > Comment at: lib/Frontend/CompilerInvocation.cpp:571 > @@ +570,3 @@ > + Opts.setDebugInfo(CodeGenOptions::LocTrackingOnly); > + Opts.DebugColumnInfo = true; > + } > ---------------- > Perhaps we could leave this out for now & just have a separate > CR/discussion about the semantics/ramifications of having this difference > between -R and -gmlt? > Hm, perhaps. I would be penalizing -Rpass, however. But I guess it doesn't matter much. I'll amend the documentation to state that -gcolumn-inf is needed with -Rpass. > > ================ > Comment at: test/Frontend/optimization-remark.c:13 > @@ +12,3 @@ > +// CHECK: , !dbg ! > +// CHECK-NOT: DW_TAG_base_type > + > ---------------- > Could have a brief comment here "Ensure -Rpass, like -gmlt, doesn't > produce debug info metadata for types". > That's what the comment above those two lines tries to do. Perhaps you want it worded differently?
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
