On 25/06/2014 09:11, David Blaikie wrote:
Takes ownership of the MemoryBuffer, is that it? You could just create a shallow MemoryBuffer (MemoryBuffer::getMemBuffer - it doesn't own the underlying memory) and give that to ParseIR - it can own the MemoryBuffer all it wants, that doesn't have to copy all that data. Would that suffice? (and/or presumably we could fix the acutal FIXME and just have that whole API not take ownership, ever?)
Yeah, that makes sense. I've landed an update to clarify ParseIR() ownership in r211861 with the corresponding clang fix in r211862, so we're no longer copying files.
Alp. -- http://www.nuanti.com the browser experts _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
