> On Jun 27, 2014, at 4:18 AM, Chandler Carruth <[email protected]> wrote: > > > On Thu, Jun 26, 2014 at 7:03 PM, Ben Langmuir <[email protected]> wrote: > We have these kinds of checks in a lot of the other Driver tests. Should we > update those as well (in general, not necessarily for this patch)? > > There are good ways to check for the binary name and sometimes a need to > check them. When you nee to do this, you can just pass > '-no-canonical-prefixes' and it works fine. The reason for trouble without > that is that the canonical path may not end in "clang" in the face of > symlinks, etc. > > However, if you are checking for "-cc1" as the anchor point in the command > line, it doesn't seem to add lots of value to also look for the binary name. > > I don't think we need to fix this eagerly though -- most of the files seem to > be working fine as-is.
SGTM, thanks for the explanation. Ben > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
