eugenis added inline comments.

================
Comment at: test/CodeGenCXX/sanitize-dtor-generated.cpp:5
@@ +4,3 @@
+
+// TODO Success pending on resolution of issue 596
+// XFAIL: *
----------------
Add the link to the issue.

================
Comment at: test/CodeGenCXX/sanitize-dtor-generated.cpp:18
@@ +17,3 @@
+};
+NonTrivial nt;
+
----------------
Why include NonTrivial in this test at all?
With just Trivial, all the checks could be replaced with just one
// CHECK: call void @__sanitizer_dtor_callback


http://reviews.llvm.org/D12616



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to