rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
Looks like I forgot to submit the comments I wrote. Anyway, looks good. ================ Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:238 @@ +237,3 @@ + continue; + const StringRef CandidateName = llvm::sys::path::filename(DirIt->path()); + if (CandidateName > SDKVersion) ---------------- We don't usually declare local StringRefs const, even to document that the value does not change. http://reviews.llvm.org/D12832 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
