> On Oct 15, 2015, at 1:42 PM, Richard Smith <rich...@metafoo.co.uk> wrote:
> 
> On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl <apra...@apple.com 
> <mailto:apra...@apple.com>> wrote:
> 
>> On Oct 14, 2015, at 5:07 PM, Richard Smith <rich...@metafoo.co.uk 
>> <mailto:rich...@metafoo.co.uk>> wrote:
>> 
>> Ack, there are non-modular headers in the Darwin module. =( I seem to recall 
>> that they're not version-locked to your compiler, so we've got to support 
>> them as-is?
>> 
>> If we can't turn on local submodule visibility, then we need a module map 
>> for libc++ that covers all of its headers. I'll look into pruning the 
>> include path when building a module from an implicitly-loaded module map.
> 
> The attached patch implements this in the most hacky way; with it I can 
> successfully compile the first few hundred files of LLVM.
> 
> Great, it looks like this plan should work then. What failure do you 
> eventually hit? Does it look related to these <foo.h> changes?

So far I fixed 250446  and 250459 which were both just missing include files. 
I’m puzzled by 250459 though, as there is nothing Darwin-specific about the 
change. I’ll keep iterating and will let you know if there are any 
libc++-related problems.

> 
> I'm working on a more refined version of the approach I described earlier; 
> I'll mail you a patch to test when I have it finished.

That sounds great.

thanks,
adrian
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to