I did not create a test checker for the NormalizeLine error in the patch. Should I add a test checker for this? Do you have any suggestions where to put it if required?
GetEnclosingDeclContextSignature already checks for nullptr, this should have been done in the NormalizeLine function also, but in that case it is not enough because the Lexer needs the LangOpts. On Tue, Nov 24, 2015 at 5:18 PM, Sean Eveson <eveson.s...@gmail.com> wrote: > seaneveson added a subscriber: seaneveson. > seaneveson added a comment. > >> If the Decl *D pointer is nullptr the NormalizeLine would crash while >> getting the LangOptions. > > > Do you have a reproducible test case for this? > > > http://reviews.llvm.org/D14919 > > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
