On Nov 25, 2015 1:53 PM, "hfin...@anl.gov via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > hfinkel added inline comments. > > ================ > Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2783 > @@ -2783,1 +2782,3 @@ > + "the newer semantic is provided here">, > + InGroup<DiagGroup<"attribute-packed-for-bitfield-semantic-changed">>; > def warn_transparent_union_attribute_field_size_align : Warning< > ---------------- > Calling this "a semantic" reads oddly to me. This sounds better to me: > > def note_attribute_packed_for_bitfield_offset_changed : Warning< > "the offset assigned to packed bit-field member %0 has changed with GCC version 4.4 - "
Please also remove the "has" here. > "the newer offset is used here">, > InGroup<DiagGroup<"attribute-packed-bitfield-offset-changed">>; > > ================ > Comment at: lib/Sema/SemaDeclAttr.cpp:1040 > @@ -1039,3 +1039,3 @@ > // If the alignment is less than or equal to 8 bits, the packed attribute > // has no effect. > if (!FD->getType()->isDependentType() && > ---------------- > This comment is now out of date? > > > http://reviews.llvm.org/D14872 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
