zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.

LGTM.

(Feel free to add comments to the existing code!)

> So the real question is whether (or rather how) the Store should maintain 
> correct region liveness information 

>  after completing its internal garbage collection pass, because there are, in 
> fact, other users of 

>  this information later in the chain, but this seems to be a larger problem 
> without instantly noticeable effects.


Could you give specific (possibly potential) examples of this problem?

We assume that the symbols that are collected do not need to stick around, so 
no-one "later in the chain" should need them. Except for the cases where we 
artificially extend liveness by calling addSymbolDependency().


http://reviews.llvm.org/D12726



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to